Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use Worker scope in WPT #24410

Closed
wants to merge 1 commit into from
Closed

test: use Worker scope in WPT #24410

wants to merge 1 commit into from

Commits on Nov 17, 2018

  1. test: use Worker scope in WPT 

    Previously, we use the Window scope by default in our WPT test
runner. When one of the test fails, the WPT harness would try to
use document.getElementsByTagName() etc. to display the failure,
which is not going to work for us.

This patch switches the scope to DedicatedWorker and use our
Worker implementation as a global - this does not test the Worker
implementation per se, just tells the WPT harness to pass the results
back to us via the callbacks we installed and not try to access
a document.

We may still need to use a Window scope when we try to run
.window.js tests in the future, but for now we only run .any.js
tests so it's fine to use a worker scope by default.
    @joyeecheung
    joyeecheung committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    280834d View commit details
    Browse the repository at this point in the history