Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two URL parser fixes #24495

Closed
wants to merge 5 commits into from
Closed

Two URL parser fixes #24495

wants to merge 5 commits into from

Commits on Nov 19, 2018

  1. Revert "url: make the context non-enumerable" 

    This reverts commit 5e1bf05, as it causes
major performance regressions during object construction.

Refs: nodejs#24218
    @TimothyGu
    TimothyGu committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    9fed0e0 View commit details
    Browse the repository at this point in the history

  2. src: set HAS_USERNAME/PASSWORD more strictly 

    Fixes: nodejs#24211
    @TimothyGu
    TimothyGu committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    6cf1769 View commit details
    Browse the repository at this point in the history

  3. url: reuse existing context in href setter 

    Correctness-wise, this removes side effects in the href setter if parsing
fails. Style-wise, this allows removing the parse() wrapper function around C++
_parse().

Also fix an existing bug with whitespace trimming in C++ that was previously
circumvented by additionally trimming the input in JavaScript.

Fixes: nodejs#24345
Refs: nodejs#24218 (comment)
    @TimothyGu
    TimothyGu committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    8be84ac View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. url: simplify native URL object construction 

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    @TimothyGu @joyeecheung
    TimothyGu and joyeecheung committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    19634c7 View commit details
    Browse the repository at this point in the history

  2. fixup! url: reuse existing context in href setter 

    Fix linting
    @TimothyGu
    TimothyGu committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    61114b1 View commit details
    Browse the repository at this point in the history