Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: harden bignum-to-binary conversions #24719

Closed
wants to merge 1 commit into from
Closed

crypto: harden bignum-to-binary conversions #24719

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Refs: #24645

@nodejs-github-bot
Copy link
Collaborator

@bnoordhuis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1722/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Nov 29, 2018
@bnoordhuis bnoordhuis mentioned this pull request Nov 29, 2018
Closed
@addaleax
Copy link
Member

addaleax commented Nov 29, 2018 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19056/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2018
@danbev
Copy link
Contributor

danbev commented Dec 3, 2018

Landed in 3513b0c.

@danbev danbev closed this Dec 3, 2018
danbev pushed a commit that referenced this pull request Dec 3, 2018
@bnoordhuis @danbev
crypto: harden bignum-to-binary conversions
3513b0c 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@bnoordhuis @BridgeAR
crypto: harden bignum-to-binary conversions
12feb9e 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@bnoordhuis @refack
crypto: harden bignum-to-binary conversions
501bc12 
PR-URL: nodejs#24719
Refs: nodejs#24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@bnoordhuis @BethGriggs
crypto: harden bignum-to-binary conversions
a2155e1 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@bnoordhuis @rvagg
crypto: harden bignum-to-binary conversions
3acf761 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bnoordhuis @nodejs-github-bot @addaleax @danbev @jasnell @cjihrig @Trott @BethGriggs