Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: improve internal isError() validation #24746

Closed
wants to merge 5 commits into from
Closed

util: improve internal isError() validation #24746

wants to merge 5 commits into from

Commits on Nov 30, 2018

  1. util: improve internal isError() validation 

    The current internal isError function checked the toString value
instead of using the more precise `util.types.isNativeError()` check.
The `instanceof` check is not removed due to possible errors that
are not native but still an instance of Error.
    @BridgeAR
    BridgeAR committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    ab135e7 View commit details
    Browse the repository at this point in the history

  2. fixup: add test case

    @BridgeAR
    BridgeAR committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    9009e4c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. fixup: add further test case

    @BridgeAR
    BridgeAR committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    434eb41 View commit details
    Browse the repository at this point in the history

  2. fixup: more verbose comment

    @BridgeAR
    BridgeAR committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    d346011 View commit details
    Browse the repository at this point in the history

  3. fixup: add test explanation

    @BridgeAR
    BridgeAR committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    ddc82e4 View commit details
    Browse the repository at this point in the history