Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: only define NODE_V8_OPTIONS if not empty #2532

Merged
merged 1 commit into from
Aug 25, 2015
Merged

build: only define NODE_V8_OPTIONS if not empty #2532

merged 1 commit into from
Aug 25, 2015

Commits on Aug 25, 2015

  1. build: only define NODE_V8_OPTIONS if not empty 

    Previously, V8::SetFlagsFromString was called on every launch even if
NODE_V8_OPTIONS was an empty string. This patch only defines
NODE_V8_OPTIONS if node_v8_options is not an empty string.

PR-URL: nodejs#2532
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @evanlucas
    evanlucas committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    d895d4a View commit details
    Browse the repository at this point in the history