Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add handle scope to OnFatalError() #25775

Closed
wants to merge 1 commit into from
Closed

src: add handle scope to OnFatalError() #25775

wants to merge 1 commit into from
+1 −0

Commits on Jan 28, 2019

  1. src: add handle scope to OnFatalError() 

    For the report generation, we use `Environment::GetCurrent(isolate)`
which uses `isolate->GetCurrentContext()` under the hood, thus
allocates a handle. Without a `HandleScope`, this is invalid.

This might not strictly be allowed inside of `OnFatalError()`,
but it won’t make anything worse either.
    @addaleax
    addaleax committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    5f107d1 View commit details
    Browse the repository at this point in the history