Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: error handler runs outside of its domain #26211

Closed
wants to merge 3 commits into from

Commits on Feb 20, 2019

  1. domain: error handler runs outside of its domain

    Before this change, domains' error handlers would run with the
    corresponding domain as the active domain. This creates the
    possibility for domains' error handlers to call themselves recursively
    if an event emitter created in the error handler emits an error, or if
    the error handler throws an error.
    
    This change sets the active domain to be the domain's parent (or null
    if the domain for which the error handler is called has no parent) to
    prevent that from happening.
    
    Fixes: nodejs#26086
    Julien Gilli committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    c3c35d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Apply suggestions from code review

    Co-Authored-By: misterdjules <jgilli@fastmail.fm>
    BridgeAR and misterdjules authored Apr 3, 2019
    Configuration menu
    Copy the full SHA
    d90a46c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. fix lint error

    Julien Gilli committed May 20, 2019
    Configuration menu
    Copy the full SHA
    386845d View commit details
    Browse the repository at this point in the history