Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix repl .load #28608

Closed
wants to merge 3 commits into from
Closed

repl: fix repl .load #28608

wants to merge 3 commits into from

Commits on Jul 9, 2019

  1. test: make repl tests more resilient 

    This refactors two tests to ignore line numbers in stack traces. That
way changed line numbers do not have any impact on the test outcome
anymore.
    @BridgeAR
    BridgeAR committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    bf9bf84 View commit details
    Browse the repository at this point in the history

  2. repl: fix autocomplete while using .load 

    This makes sure that complete functions work as expected after using
the REPL's `.load` command.

It also fixes the corresponding test. So far the assertion where
swallowed and the test passed even though it should not have.

Fixes: nodejs#28546
    @BridgeAR
    BridgeAR committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    aba0ff3 View commit details
    Browse the repository at this point in the history

  3. fixup: repl: fix autocomplete while using .load 

    Instead of optionally removing the newline, just do not add one
in the first place. That way the actual content is preserved
correctly.
    @BridgeAR
    BridgeAR committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    9a19d48 View commit details
    Browse the repository at this point in the history