Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove leading line in changlog #29463

Closed
wants to merge 1 commit into from
Closed

doc: remove leading line in changlog #29463

wants to merge 1 commit into from

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Sep 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nschonni
doc: remove leading line in changlog
8d9201a 
This last file triggering remark-lint no-consecutive-blank-lines rule
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 5, 2019
@nschonni nschonni mentioned this pull request Sep 5, 2019
Merged
@Trott
Copy link
Member

Trott commented Sep 5, 2019

Partial duplicate of #29447?

@nschonni
Copy link
Member Author

nschonni commented Sep 5, 2019

Yup, including it with the bump probably makes sense, so I'll close this one

@nschonni nschonni closed this Sep 5, 2019
@nschonni nschonni deleted the doc--remove-leading-line-in-v8-changlog branch September 5, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nschonni @Trott @nodejs-github-bot