Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: make FSWatcher.start private #29905

Closed
wants to merge 2 commits into from
Closed

fs: make FSWatcher.start private #29905

wants to merge 2 commits into from

Commits on Oct 9, 2019

  1. fs: make FSWatcher.start private 

    * This is a semver-major change to rename the FSWatcher.start
function to FSWatcher._start to make it private

The motivation here is that it serves no purpose to the end user.
An instance of FSWatcher is returned when a user calls fs.watch,
which will call the start method.  A user can't create an instance
of a FSWatcher directly.  If the start method is called by a user
it is a noop since the watcher has already started.  Calling start
after a watcher has closed is also a noop
    @lholmquist
    lholmquist committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    62ec127 View commit details
    Browse the repository at this point in the history

  2. squash: use symbols for private

    @lholmquist
    lholmquist committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    984fa00 View commit details
    Browse the repository at this point in the history