Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor common.expectsError #31092

Closed
wants to merge 2 commits into from
Closed

test: refactor common.expectsError #31092

wants to merge 2 commits into from

Commits on Dec 25, 2019

  1. test: refactor common.expectsError 

    This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.
    @BridgeAR
    BridgeAR committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    f71f226 View commit details
    Browse the repository at this point in the history

  2. fixup: add missing doc reference

    @BridgeAR
    BridgeAR committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    a419633 View commit details
    Browse the repository at this point in the history