Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use is None consistently in Python #36606

Merged
merged 3 commits into from
Dec 25, 2020
Merged

tools: use is None consistently in Python #36606

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36c17e2
tools: use `is None` consistently in Python
Trott Dec 22, 2020
18fc50f
tools: call close() explicitly in genv8constants.py
Trott Dec 22, 2020
e068eec
tools: correct usage message for genv8constants.py
Trott Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tools/genv8constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import errno

if len(sys.argv) != 3:
print("usage: objsym.py outfile libv8_base.a")
print("Usage: genv8constants.py outfile libv8_base.a")
sys.exit(2)

outfile = open(sys.argv[1], 'w')
Expand Down Expand Up @@ -95,7 +95,7 @@ def out_define():
curr_octet += 1

match = pattern.match(line)
if match == None:
if match is None:
continue

# Print previous symbol
Expand All @@ -113,3 +113,5 @@ def out_define():

#endif /* V8_CONSTANTS_H */
""")

outfile.close()