Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve crypto.randomUUID() text #36830

Merged
merged 1 commit into from
Jan 8, 2021
Merged

doc: improve crypto.randomUUID() text #36830

merged 1 commit into from
Jan 8, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 7, 2021

  • Use present tense.
  • Remove "persistently" which suggests that the cache persists across
    Node.js runs.
  • Remove "pre-emptively". I think "proactively" is what was meant as
    nothing is being pre-empted here. Regardless of what the adverby
    should be, it seems unnecessary.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jan 7, 2021
@jasnell
Copy link
Member

jasnell commented Jan 7, 2021

Seems unnecessary to wait the full time to land. Fast-track?

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 7, 2021
* Use present tense.
* Remove "persistently" which suggests that the cache persists across
  Node.js runs.
* Remove "pre-emptively". I think "proactively" is what was meant as
  nothing is being pre-empted here. Regardless of what the adverby
  should be, it seems unnecessary.

PR-URL: nodejs#36830
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 8, 2021

Landed in 15e47ed

@Trott Trott merged commit 15e47ed into nodejs:master Jan 8, 2021
@Trott Trott deleted the will branch January 8, 2021 00:08
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
* Use present tense.
* Remove "persistently" which suggests that the cache persists across
  Node.js runs.
* Remove "pre-emptively". I think "proactively" is what was meant as
  nothing is being pre-empted here. Regardless of what the adverby
  should be, it seems unnecessary.

PR-URL: #36830
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants