test: mark test-cluster-bind-privileged-port flaky on arm #36850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
flaky-test
github-actions
bot
removed
the
request-ci
|
Please 👍🏻 to fast track so we can unblock CI |
Trott
reviewed
Jan 8, 2021
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Per rvagg: ``` Persistent failure, even after restarts of the whole cluster. nodejs#36478 was merged into this test yesterday but the parent commit still has the failures. What has changed is the Docker version. They all got an upgrade to 5:20.10.2~3-0~raspbian-buster and this is all running inside containers. It's going to be the newest version of Docker running in our CI and I wonder whether we're going to see similar failures when we upgrade other hosts or if this is going to be restricted to ARM. Other than that, I'm not sure what this could be. It seems like a straightforward test that shouldn't fail, maybe Docker has introduced something new for unprivileged port binding inside containers? ``` Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
flaky-cluster-bind-privileged-port
branch
from
df3373e
to
a62b67c
Compare
jasnell
added
the
author ready
mmarchini
approved these changes
Jan 8, 2021
|
Landed in a45a404 |
jasnell
added a commit
that referenced
this pull request
Jan 8, 2021
Per rvagg: ``` Persistent failure, even after restarts of the whole cluster. #36478 was merged into this test yesterday but the parent commit still has the failures. What has changed is the Docker version. They all got an upgrade to 5:20.10.2~3-0~raspbian-buster and this is all running inside containers. It's going to be the newest version of Docker running in our CI and I wonder whether we're going to see similar failures when we upgrade other hosts or if this is going to be restricted to ARM. Other than that, I'm not sure what this could be. It seems like a straightforward test that shouldn't fail, maybe Docker has introduced something new for unprivileged port binding inside containers? ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36850 Refs: #36847 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
2 tasks
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Jan 12, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: nodejs#36850 Ref: nodejs#36847 Ref: nodejs/build#2521
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Per rvagg: ``` Persistent failure, even after restarts of the whole cluster. #36478 was merged into this test yesterday but the parent commit still has the failures. What has changed is the Docker version. They all got an upgrade to 5:20.10.2~3-0~raspbian-buster and this is all running inside containers. It's going to be the newest version of Docker running in our CI and I wonder whether we're going to see similar failures when we upgrade other hosts or if this is going to be restricted to ARM. Other than that, I'm not sure what this could be. It seems like a straightforward test that shouldn't fail, maybe Docker has introduced something new for unprivileged port binding inside containers? ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36850 Refs: #36847 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jan 18, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear why the test is suddenly persistently failing only on arm but it's completely blocking being able to land other PRs
Refs: #36847
Per @rvagg:
Signed-off-by: James M Snell jasnell@gmail.com