Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move OPENSSL_API_COMPAT to else clause #38126

Closed
wants to merge 1 commit into from
Closed

build: move OPENSSL_API_COMPAT to else clause #38126

wants to merge 1 commit into from

Commits on Apr 7, 2021

  1. build: move OPENSSL_API_COMPAT to else clause 

    Currently there are a number of deprecation warnings generated when
linking with OpenSSL 3.0, for example:

In file included from ../src/crypto/crypto_scrypt.h:6,
                 from ../src/crypto/crypto_scrypt.cc:1:
../src/crypto/crypto_util.h:64:37: warning:
‘void RSA_free(RSA*)’ is deprecated: Since OpenSSL 3.0
[-Wdeprecated-declarations]
   64 | using RSAPointer = DeleteFnPtr<RSA, RSA_free>;

The reason for this is that I had placed the macro OPENSSL_API_COMPAT
inside of the node_shared_openssl="false" clause, but that was a
mistake and this macro should have gone into the else clause instead.
    @danbev
    danbev committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    9a90760 View commit details
    Browse the repository at this point in the history