Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move slower tests into pummel and skip on slow devices #38395

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 25, 2021

Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: #34289 (comment)

@Trott Trott requested a review from targos April 25, 2021 04:36
@nodejs-github-bot

This comment has been minimized.

@targos targos added the test Issues and PRs related to the tests. label Apr 25, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Apr 26, 2021

Fast-track to help our backed-up arm-fanned CI jobs?

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 26, 2021
@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2021
Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: nodejs#34289 (comment)

PR-URL: nodejs#38395
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 27, 2021

Landed in 7f56307

@Trott Trott merged commit 7f56307 into nodejs:master Apr 27, 2021
@Trott Trott deleted the move-some-pummels branch April 27, 2021 04:22
targos pushed a commit that referenced this pull request Apr 29, 2021
Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: #34289 (comment)

PR-URL: #38395
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants