Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: add JSDoc typings for https #38589

Closed
wants to merge 2 commits into from

Conversation

VoltrexKeyva
Copy link
Member

Added JSDoc typings for the https lib module.

Added JSDoc typings for the `https` lib module.
@github-actions github-actions bot added https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run. labels May 8, 2021
lib/https.js Outdated Show resolved Hide resolved
Marked `requestListener` as an optional parameter.

Co-authored-by: akhil marsonya <16393876+marsonya@users.noreply.github.com>
@marsonya marsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 24, 2021

@jasnell
Copy link
Member

jasnell commented May 24, 2021

Landed in 9a7cbe2

@jasnell jasnell closed this May 24, 2021
jasnell pushed a commit that referenced this pull request May 24, 2021
Added JSDoc typings for the `https` lib module.

PR-URL: #38589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@VoltrexKeyva VoltrexKeyva deleted the patch-2 branch May 24, 2021 21:02
danielleadams pushed a commit that referenced this pull request May 31, 2021
Added JSDoc typings for the `https` lib module.

PR-URL: #38589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
richardlau pushed a commit that referenced this pull request Jul 16, 2021
Added JSDoc typings for the `https` lib module.

PR-URL: #38589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
Added JSDoc typings for the `https` lib module.

PR-URL: #38589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
Added JSDoc typings for the `https` lib module.

PR-URL: #38589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Added JSDoc typings for the `https` lib module.

PR-URL: nodejs#38589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants