buffer: add blob endings option, remove Node.js specific encoding option #39708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
aduh95
approved these changes
Aug 8, 2021
addaleax
reviewed
Aug 8, 2021
VoltrexKeyva
reviewed
Aug 9, 2021
This comment has been minimized.
This comment has been minimized.
5 tasks
Signed-off-by: James M Snell <jasnell@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
added
author ready
|
Ordinarily this would have been a semver-major change. You consider this a patch because it's a spec violation? I'm on board with that, but maybe we should document it somewhere. |
|
Blob support is still experimental, this doesn't have to be semver-major. |
|
Ah, I missed it! I thought it was not but it was just a few lines above the diff, my bad! |
jasnell
added a commit
that referenced
this pull request
Aug 14, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in fcf8ba4 |
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the #39693 and includes the commits from that PR.This removes the non-standard
'encoding'option on theBlobconstructor and adds the standard'endings'option.