added 'file://' in errors.md for ES modules #39882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
aduh95
reviewed
Aug 25, 2021
| @@ -343,6 +343,7 @@ The location information will be one of: | |||
| to Node.js. | |||
| * `/absolute/path/to/file.js:line:column`, if the frame represents a call in | |||
| a user program, or its dependencies. | |||
| * `file:///absolute/path/to/file.js:line:column`, if the frame represents a call in ES module files. | |||
There was a problem hiding this comment.
Suggested change
| * `file:///absolute/path/to/file.js:line:column`, if the frame represents a call in ES module files. | |
| * `file:///absolute/fileURL/to/file.js:line:column`, if the frame represents a | |
| call in an ECMAScript module. |
aduh95
reviewed
Aug 25, 2021
| @@ -343,6 +343,7 @@ The location information will be one of: | |||
| to Node.js. | |||
| * `/absolute/path/to/file.js:line:column`, if the frame represents a call in | |||
| a user program, or its dependencies. | |||
There was a problem hiding this comment.
Suggested change
| a user program, or its dependencies. | |
| a CommonJS module. |
Closed
|
It looks like a fix has already landed in 1e34969. Thanks for contribution, sorry it didn't go through this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at resolving issue #39787.
I added a separate bullet point for the errors in ES module files.