Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update onboarding task #40570

Closed
wants to merge 2 commits into from
Closed

doc: update onboarding task #40570

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 22, 2021

Make starting Jenkins CI optional.

Make starting Jenkins CI optional.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 22, 2021
onboarding.md Outdated Show resolved Hide resolved
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2021
Comment on lines +219 to +220
task. As a convenience, you may apply the `request-ci` label to the pull
request to have a GitHub Actions workflow start the Jenkins CI task for you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request-ci has no time guarentee, I don't think it would be very convenient for an onboarding session. Maybe that doesn't matter since it's optional anyway, but I wanted to point it out in case you didn't think of it.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2021
@github-actions
Copy link
Contributor

Landed in ce0e21e...566365d

@github-actions github-actions bot closed this Oct 24, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 24, 2021
Make starting Jenkins CI optional.

PR-URL: #40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
Make starting Jenkins CI optional.

PR-URL: #40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
Make starting Jenkins CI optional.

PR-URL: #40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
@Trott Trott deleted the optional-ci branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants