Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 8.4.1 #41836

Merged
merged 1 commit into from
Feb 7, 2022
Merged

deps: upgrade npm to 8.4.1 #41836

merged 1 commit into from
Feb 7, 2022

Conversation

npm-robot
Copy link
Contributor

v8.4.1 (2022-02-03)

Bug Fixes

Documentation

Dependencies

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Feb 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@ruyadorno ruyadorno added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit af7caf8 into nodejs:master Feb 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in af7caf8

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41836
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
ruyadorno added a commit that referenced this pull request Feb 8, 2022
Notable changes:

lib:
  * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
module:
  * unflag esm json modules (Geoffrey Booth) #41736
node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
stream:
  * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
deps:
  * upgrade npm to 8.4.1 (npm team) [#41836](#41836)
ruyadorno added a commit that referenced this pull request Feb 8, 2022
Notable changes:

lib:
  * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
module:
  * unflag esm json modules (Geoffrey Booth) #41736
node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
stream:
  * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
deps:
  * upgrade npm to 8.4.1 (npm team) [#41836](#41836)
ruyadorno added a commit that referenced this pull request Feb 8, 2022
Notable changes:

lib:
  * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
module:
  * unflag esm json modules (Geoffrey Booth) #41736
node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
stream:
  * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
deps:
  * upgrade npm to 8.4.1 (npm team) [#41836](#41836)
ruyadorno added a commit that referenced this pull request Feb 10, 2022
Notable changes:

lib:
  * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
module:
  * unflag esm json modules (Geoffrey Booth) #41736
node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
stream:
  * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
deps:
  * upgrade npm to 8.4.1 (npm team) [#41836](#41836)

PR-URL: #41897
ruyadorno added a commit that referenced this pull request Feb 10, 2022
Notable changes:

lib:
  * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
module:
  * unflag esm json modules (Geoffrey Booth) #41736
node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
stream:
  * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
deps:
  * upgrade npm to 8.4.1 (npm team) [#41836](#41836)

PR-URL: #41897
@bonesoul
Copy link

8.4.1 is still broken on windows, did u considered this while merging this?

@DerekNonGeneric
Copy link
Contributor

@bonesoul, v8.5.0 (#41925) will likely be going out in the next release(s) unless there are further updates between now and then.

Have you tested whether that version works well enough? It would be great to know ahead of time.

@targos
Copy link
Member

targos commented Feb 11, 2022

@bonesoul I'm not sure we are aware that npm is broken on Windows. Is there an open issue about it?

@bonesoul
Copy link

bonesoul commented Feb 11, 2022

@targos here you go: npm/cli#4234 (comment)

@DerekNonGeneric npm started failing with 8.4.0. Last working version for me on windows is npm 8.3.2.
npm 8.5.0 also seems to be fixed.

But this fail made node 17.4.0 and 17.5.0 unusable for windows users at all. Any chances we can see a hotfix that can push npm 8.5.0 maybe?

@RodEsp
Copy link

RodEsp commented Feb 11, 2022

npm 8.3.1 is broken too which is what's shipping with node lts right now.

@DerekNonGeneric
Copy link
Contributor

Any chances we can see a hotfix that can push npm 8.5.0 maybe?

I am not sure I've ever seen us do something like that, but this may be justifiable (not sure).

/cc @nodejs/releasers

@BethGriggs
Copy link
Member

Any chances we can see a hotfix that can push npm 8.5.0 maybe?

I am not sure I've ever seen us do something like that, but this may be justifiable (not sure).

Yes, in cases like these we often ship an interim/expedited release to fix. Sounds like we will need to ship patch releases for both 16 and 17 (likely to be next week now).

/cc @nodejs/npm

MylesBorins pushed a commit that referenced this pull request Feb 12, 2022
PR-URL: #41836
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@MylesBorins
Copy link
Contributor

@bonesoul are using nvm-windows to install node.js? We have a report on the npm/cli repo that seems to imply that these versions of npm are working fine on windows with a more recent version of nvm-windows and other team members have testing with the official installer and not had an issue.

@bonesoul
Copy link

well i'm using nvm-windows. then that's the case?

@MylesBorins
Copy link
Contributor

@bonesoul can you try updating nvm-windows and see if that fixes it?

@bonesoul
Copy link

bonesoul commented Feb 13, 2022

the issue is fixed for me using the latest nvm-windows but here you can see reports that the issue still exists with latest nvm-windows: npm/cli#4234 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.