Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: delete llnode from diagnostic tooling support tiers #43289

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

tony-go
Copy link
Member

@tony-go tony-go commented Jun 1, 2022

Hey node family 👋

Context

The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.

Updated

In the previous instance, we examined the case of the llnode module: issue link.

It seems that we don't have a clear idea about the current status of this tool. Until we can clarify the status of this tool, we prefer to remove it from the list.

In parallel, @gireeshpunathil will try to contact potential contributors to see how could we fill the gap.

Discuss

As usual, feel free to share your thoughts on that and your experience with this tool.

With love ❤️

cc @nodejs/diagnostics

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 1, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@legendecas
Copy link
Member

/cc @mmarchini

@RaisinTen
Copy link
Contributor

cc @nodejs/llnode

lpinca
lpinca previously approved these changes Jun 3, 2022
@lpinca lpinca dismissed their stale review June 3, 2022 19:07

I'm actually not sure if it makes sense to remove it.

@bnoordhuis
Copy link
Member

@gireeshpunathil I believe you found a volunteer?

@joyeecheung
Copy link
Member

Speaking as someone who used to do some maintenance work on llnode - I don’t think it’s now maintained enough to be considered supported, I do sometimes miss it when I need to grok V8 coredumps or certain kinds of crashed V8 processes, though sadly I don’t think I currently have the bandwidth to keep it in shape either..

@gireeshpunathil
Copy link
Member

@gireeshpunathil I believe you found a volunteer?

Yes, but given the time to ramp up, I think it makes sense to take it off the list as of now, and add it back at a later point when we think it is sufficiently maintained?

@lpinca
Copy link
Member

lpinca commented Jun 11, 2022

@tony-go can you please remove the merge commit?

@tony-go
Copy link
Member Author

tony-go commented Jun 12, 2022

cc @lpinca

@Qard
Copy link
Member

Qard commented Jun 12, 2022

I would also be interested in contributing when I can as I use it regularly. I don't have much bandwidth so don't want to be the only person on it, but if there's any calls happening to get others up to speed, please invite me too.

@tony-go
Copy link
Member Author

tony-go commented Jun 12, 2022

I also offer my help during the last WG meeting. Definitely not familiar with this kind of project, but it's surely a good opportunity to learn ^^

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4f3b8fa into nodejs:master Jun 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4f3b8fa

danielleadams pushed a commit that referenced this pull request Jun 14, 2022
PR-URL: #43289
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43289
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43289
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43289
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.