Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: make built in reporters internal #46092

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 4, 2023

This commit updates the test runner to make the built in test reporters internal modules.

Fixes: #46061 (comment)

This commit updates the test runner to make the built in test
reporters internal modules.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 4, 2023
@cjihrig cjihrig mentioned this pull request Jan 4, 2023
3 tasks
@aduh95 aduh95 added experimental Issues and PRs related to experimental features. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2023
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@MoLow MoLow added the test_runner Issues and PRs related to the test runner subsystem. label Jan 4, 2023
@cjihrig cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 5, 2023
@jaydenseric jaydenseric mentioned this pull request Jan 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4788c0d into nodejs:main Jan 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4788c0d

@cjihrig cjihrig deleted the reporters branch January 6, 2023 19:55
@RafaelGSS
Copy link
Member

Hi @cjihrig! It didn't land cleanly on v19.x-staging, I'm pretty sure that's due to the fact of dependents' PRs are tagged with dont-land-on-vX. I'll skip this commit on v19.5.0 proposal, but when all the fixes were addressed you can ping me, I can include it in the v19.5.0 proposal.

In any case I'm adding the label backport-requested.

@bricss bricss mentioned this pull request Jan 22, 2023
@juanarbol juanarbol added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jan 25, 2023
@juanarbol
Copy link
Member

This is not landing cleanly in v18.x 💔

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 25, 2023

This (and probably most other test runner commits) cannot be backported until #45712 is backported.

MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@MoLow MoLow added backport-open-v18.x Indicate that the PR has an open backport. backport-open-v19.x and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. backport-requested-v19.x labels Jan 26, 2023
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ruyadorno pushed a commit that referenced this pull request Jan 31, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

Backport-PR-URL: #46361
PR-URL: #46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 6, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@MoLow MoLow mentioned this pull request Mar 3, 2023
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: #46092
Backport-PR-URL: #46839
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: #46092
Backport-PR-URL: #46839
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v18.x Indicate that the PR has an open backport. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants