Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix notable-change comment label url #47300

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

panva
Copy link
Member

@panva panva commented Mar 29, 2023

#47078 was merged before #47078 (comment) was dealt with.

This follow up does exactly that, hard codes the url to display the label like so notable-change PRs with changes that should be highlighted in changelogs.

@panva panva added the meta Issues and PRs related to the general management of the project. label Mar 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2023
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link rendering doesn't work on the GitHub mobile app but I guess there's nothing we can do about it.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 21f0620 into nodejs:main Mar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 21f0620

@panva panva deleted the fix-notable-change-comment branch March 31, 2023 17:49
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
PR-URL: #47300
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
PR-URL: #47300
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47300
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
PR-URL: #47300
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47300
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants