Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add eventtarget creation bench #47774

Merged

Conversation

RafaelGSS
Copy link
Member

This proved to be a useful benchmark. FWIW We have a regression in creating EventTarget in Node.js v20.

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. labels Apr 28, 2023
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2023
@debadree25
Copy link
Member

FWIW We have a regression in creating EventTarget in Node.js v20.

Any pointers you found on what may have caused it?

@RafaelGSS
Copy link
Member Author

FWIW We have a regression in creating EventTarget in Node.js v20.

Any pointers you found on what may have caused it?

I'm planning to post all the regressions in the nodejs/performance repository once I finish the analysis.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2023
@nodejs-github-bot nodejs-github-bot merged commit b5fe45f into nodejs:main Apr 30, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b5fe45f

targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47774
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request May 2, 2023
targos pushed a commit that referenced this pull request May 3, 2023
PR-URL: #47774
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47774
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47774
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants