doc: fix Windows code snippet tags #48100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those were wrongly marked as `bash`, when the text around it was referencing PowerShell or Command Prompt.
|
Review requested:
|
targos
approved these changes
May 21, 2023
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
tniessen
approved these changes
May 21, 2023
VoltrexKeyva
approved these changes
May 21, 2023
RaisinTen
reviewed
May 21, 2023
| cp (Get-Command node).Source hello.exe | ||
| ``` | ||
|
|
||
| Using Command Prompt: | ||
|
|
||
| ```bash | ||
| ```text |
There was a problem hiding this comment.
Suggested change
| ```text | |
| ```cmd |
Shouldn't this be cmd?
There was a problem hiding this comment.
The linter won’t let me do that.
There was a problem hiding this comment.
Okay, so here's the total list:
node/tools/lint-md/lint-md.mjs
Lines 20828 to 20843 in 260092e
I think
console still makes more sense than text here.
There was a problem hiding this comment.
I disagree, console is meant for showing the output of commands (with optionally the command themselves when prefixed with $ or >), so it wouldn’t apply here. If you feel strongly that text is not correct, let’s add cmd to the list.
There was a problem hiding this comment.
I don't feel strongly about it :)
Mesteery
approved these changes
May 21, 2023
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 30870d1 |
fasenderos
pushed a commit
to fasenderos/node
that referenced
this pull request
May 22, 2023
Those were wrongly marked as `bash`, when the text around it was referencing PowerShell or Command Prompt. PR-URL: nodejs#48100 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
fasenderos
pushed a commit
to fasenderos/node
that referenced
this pull request
May 22, 2023
Those were wrongly marked as `bash`, when the text around it was referencing PowerShell or Command Prompt. PR-URL: nodejs#48100 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
Those were wrongly marked as `bash`, when the text around it was referencing PowerShell or Command Prompt. PR-URL: #48100 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
added
the
backport-blocked-v18.x
|
Blocked by #47125 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Those were wrongly marked as `bash`, when the text around it was referencing PowerShell or Command Prompt. PR-URL: nodejs#48100 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Those were wrongly marked as `bash`, when the text around it was referencing PowerShell or Command Prompt. PR-URL: nodejs#48100 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those were wrongly marked as
bash(that's my bad, it's coming from #48082), when the text around it was referencing PowerShell or Command Prompt.