Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,vm: clarify usage of cachedData in vm.compileFunction() #48193

Conversation

RaisinTen
Copy link
Contributor

Fixes: #48175

Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels May 26, 2023
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2023
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 023e880 into nodejs:main May 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 023e880

@RaisinTen RaisinTen deleted the doc-vm-clarify-usage-of-cachedData-in-compileFunction branch May 29, 2023 01:27
targos pushed a commit that referenced this pull request May 30, 2023
Fixes: #48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Fixes: #48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function returned by vm.compileFunction can't accept arguments when cachedData is passed
4 participants