Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: eliminate performance cost of ESM syntax detection for CommonJS entry points #52093

Merged
merged 16 commits into from
Mar 20, 2024
Merged

module: eliminate performance cost of ESM syntax detection for CommonJS entry points #52093

merged 16 commits into from
Mar 20, 2024

Commits on Mar 18, 2024

  1. module: eliminate performance cost of detection for cjs entry

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5aa3528 View commit details
    Browse the repository at this point in the history

  2. DRY the C++ functions

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    29f5a6d View commit details
    Browse the repository at this point in the history

  3. restore warning to be printed only on error

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    75dba32 View commit details
    Browse the repository at this point in the history

  4. add TypeScript fixture to benchmark

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f06b12e View commit details
    Browse the repository at this point in the history

  5. put try/catch inside our flag, to postpone for now having to deal wit… 

    …h the exception handling for unflagged usage
    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c82a15a View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    @GeoffreyBooth @joyeecheung
    GeoffreyBooth and joyeecheung committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4b6a52a View commit details
    Browse the repository at this point in the history

  7. Remove cjsRetryAsESMCache

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    65d690b View commit details
    Browse the repository at this point in the history

  8. ScriptCompiler::kNoCompileOptions

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9ad9ace View commit details
    Browse the repository at this point in the history

  9. export error messages from c++ as constants

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4ad9958 View commit details
    Browse the repository at this point in the history

  10. USE()

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    43eb1b5 View commit details
    Browse the repository at this point in the history

  11. format

    @GeoffreyBooth
    GeoffreyBooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    51268ec View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. review notes

    @GeoffreyBooth
    GeoffreyBooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1c6496c View commit details
    Browse the repository at this point in the history

  2. Use string approach

    @GeoffreyBooth
    GeoffreyBooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1685245 View commit details
    Browse the repository at this point in the history

  3. simplify array conversion

    @GeoffreyBooth
    GeoffreyBooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8d7e077 View commit details
    Browse the repository at this point in the history

  4. lint

    @GeoffreyBooth
    GeoffreyBooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d69398a View commit details
    Browse the repository at this point in the history

  5. nit

    @GeoffreyBooth
    GeoffreyBooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    fd2e330 View commit details
    Browse the repository at this point in the history