Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to version 2.1.0 #5214

Closed
wants to merge 4 commits into from
Closed

tools: update ESLint to version 2.1.0 #5214

wants to merge 4 commits into from

Commits on Feb 18, 2016

  1. src,test,tools: modify for more stringent linting 

    ESLint 2.0 is coming. Some lint rules have been tightened.

PR-URL: nodejs#5214
    @Trott
    Trott committed Feb 18, 2016
    Configuration menu
    Copy the full SHA
    0d37bb9 View commit details
    Browse the repository at this point in the history

  2. tools: remove obsolete lint rules 

    We are about to upgrade from ESlint 1 to ESLint 2. Remove lint rules
that will not exist in ESLint 2.
    @Trott
    Trott committed Feb 18, 2016
    Configuration menu
    Copy the full SHA
    1794253 View commit details
    Browse the repository at this point in the history

  3. tools: update ESLint to version 2.1.0 

    Update ESLint to 2.1.0. ESLint has a number of potentially-useful new
features but this change attempts to be minimal in its changes.
However, some things could not be avoided reasonably.

ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with
template strings that did not take advantage of any features of
template strings, and `let` declarations where `const` sufficed.

Additionally, ESLint 2.1.0 removes some granularity around enabling ES6
features. Some features (e.g., spread operator) that had been turned off
in our configuration for ESLint 1.x are now permitted.

PR-URL: nodejs#5214
    @Trott
    Trott committed Feb 18, 2016
    Configuration menu
    Copy the full SHA
    202ec87 View commit details
    Browse the repository at this point in the history

  4. tools: replace obsolete ESLint rules 

    Now that we are using ESLint 2, replace ESLint 1 rules with their ESLint
2 equivalents.

PR-URL: nodejs#5214
    @Trott
    Trott committed Feb 18, 2016
    Configuration menu
    Copy the full SHA
    7dd31f5 View commit details
    Browse the repository at this point in the history