-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: warn on detection in typeless package #52168
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
GeoffreyBooth:detect-module-warning
Mar 23, 2024
Merged
module: warn on detection in typeless package #52168
nodejs-github-bot
merged 1 commit into
nodejs:main
from
GeoffreyBooth:detect-module-warning
Mar 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyBooth
added
module
Issues and PRs related to the module subsystem.
esm
Issues and PRs related to the ECMAScript Modules implementation.
labels
Mar 21, 2024
Review requested:
|
mcollina
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
H4ad
approved these changes
Mar 21, 2024
H4ad
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Mar 21, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 21, 2024
joyeecheung
approved these changes
Mar 21, 2024
aduh95
approved these changes
Mar 22, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 22, 2024
GeoffreyBooth
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Mar 22, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 23, 2024
Landed in f4a0a3b |
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Mar 25, 2024
PR-URL: nodejs#52168 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#52168 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
added
backport-requested-v20.x
PRs awaiting manual backport to the v20.x-staging branch.
backport-blocked-v20.x
PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport.
and removed
backport-requested-v20.x
PRs awaiting manual backport to the v20.x-staging branch.
labels
May 21, 2024
targos
removed
the
backport-blocked-v20.x
PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport.
label
Sep 21, 2024
targos
pushed a commit
that referenced
this pull request
Sep 21, 2024
PR-URL: #52168 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
esm
Issues and PRs related to the ECMAScript Modules implementation.
module
Issues and PRs related to the module subsystem.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #52093 (comment), this PR prints a warning when a
.js
file runs as ESM due to detection, if that file is within the scope of apackage.json
file that lacks atype
field. In discussion with @joyeecheung we decided to warn once per applicablepackage.json
file, so that the warning corresponds with a straightforward remediation.