Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: reduce usage of self = this #5231

Closed
wants to merge 1 commit into from
Closed

Conversation

JacksonTian
Copy link
Contributor

Actually, there are unnecessary self = this.

Actually, there are unnecessary `self = this`.
@thefourtheye thefourtheye added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 15, 2016
@thefourtheye
Copy link
Contributor

@jasnell
Copy link
Member

jasnell commented Feb 15, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 21, 2016
Remove unnecessary `self = this`.

PR-URL: #5231
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 21, 2016

Landed in d2b93e5

@jasnell jasnell closed this Mar 21, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
Remove unnecessary `self = this`.

PR-URL: #5231
Reviewed-By: James M Snell <jasnell@gmail.com>

Conflicts:
	lib/domain.js
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
Remove unnecessary `self = this`.

PR-URL: #5231
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

In the backporting of this to v4.x I've removed the changes to lib/domain.js as self is still necessary in that tree.

MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
Remove unnecessary `self = this`.

PR-URL: #5231
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants