test_runner: adding colors to the xs and dots in the dot test runner #53450

puskin94 · 2024-06-14T09:14:07Z

Making sure that, when executing the dot test reporter, dots are white and Xs are red, for better visibility

nodejs-github-bot · 2024-06-14T09:14:11Z

Review requested:

@nodejs/test_runner

MoLow · 2024-06-14T09:23:10Z

lib/internal/test_runner/reporter/dot.js

 const { formatTestReport } = require('internal/test_runner/reporter/utils');
+const { red, white, green, clear } = require('internal/util/colors');


please avoid destructuring here so colors.refresh will still work

@MoLow thanks for the super prompt response :)

I applied the code change, but I don't see any reference to colors.refresh, can you pinpoint me to the right place?

RedYetiDev · 2024-06-14T12:58:08Z

IIRC isn't there a PR already open doing this?

Maybe one or the other should be closed in favor?

puskin94 · 2024-06-14T13:00:41Z

IIRC isn't there a PR already open doing this?

Maybe one or the other should be closed in favor?

yeah I noticed, but I pushed mine forward anyway because the creator or the other PR didn't push in the last 2 months

RedYetiDev · 2024-06-14T13:02:18Z

No problem! If this gets merged, I'll close the other one.

atlowChemi · 2024-06-14T14:49:51Z

lib/internal/test_runner/reporter/dot.js

 const { formatTestReport } = require('internal/test_runner/reporter/utils');
+const colors = require('internal/util/colors');


This seems like an unrelated change, could you revert it? (The import existed already in the line above)

@atlowChemi done!

jakecastelli · 2024-06-14T15:34:01Z

Good work on pushing the progress! (Just a thought - I think the origin author might deserve a co-author in the commit message? As the change looks quite identical).

atlowChemi · 2024-06-14T15:44:58Z

@puskin94 the PR changes the test_runner submodule, so the first commit message should be prefixed with test_runner and not lib.
Could you please rebase and fix the message? Let me know if you need assistance with that 🙂

puskin94 · 2024-06-15T08:27:47Z

@puskin94 the PR changes the test_runner submodule, so the first commit message should be prefixed with test_runner and not lib. Could you please rebase and fix the message? Let me know if you need assistance with that 🙂

@atlowChemi it took me a bit to understand the right order of execution of the commands, but we should be there now :) Thanks!

nodejs-github-bot · 2024-06-15T23:27:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59803/

puskin94 · 2024-06-24T12:31:20Z

Can anyone help me out here? I see the PR is stuck and I guess it is because of broken jenkins tests...
I tried to reproduce them but everything is passing locally.
What should I do? How can I move?

Thanks in advance!

MoLow · 2024-06-26T06:45:33Z

well this is an example of a failure:

02:35:52         # Subtest: test-runner/output/dot_output_custom_columns.js
02:35:52         not ok 42 - test-runner/output/dot_output_custom_columns.js
02:35:52           ---
02:35:52           duration_ms: 265.745104
02:35:52           location: '/home/iojs/build/workspace/node-test-commit-arm/test/parallel/test-runner-output.mjs:156:5'
02:35:52           failureType: 'testCodeFailure'
02:35:52           error: |-
02:35:52             Expected values to be strictly equal:
02:35:52             + actual - expected
02:35:52             
02:35:52             + '..............................\n' +
02:35:52             +   '.........................................\n' +
02:35:52             +   '.............................\n'
02:35:52             - '[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c\n' +
02:35:52             -   '[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c\n' +
02:35:52             -   '[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c\n'
02:35:52           code: 'ERR_ASSERTION'
02:35:52           name: 'AssertionError'
02:35:52           expected: |-
02:35:52             [32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c
02:35:52             [32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c
02:35:52             [32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c
02:35:52             
02:35:52           actual: |-
02:35:52             ..............................
02:35:52             .........................................
02:35:52             .............................
02:35:52             
02:35:52           operator: 'strictEqual'
02:35:52           stack: |-
02:35:52             assertSnapshot (/home/iojs/build/workspace/node-test-commit-arm/test/common/assertSnapshot.js:56:12)
02:35:52             async Module.spawnAndAssert (/home/iojs/build/workspace/node-test-commit-arm/test/common/assertSnapshot.js:84:3)
02:35:52             async TestContext.<anonymous> (file:///home/iojs/build/workspace/node-test-commit-arm/test/parallel/test-runner-output.mjs:150:5)
02:35:52             async Test.run (node:internal/test_runner/test:857:9)
02:35:52             async Promise.all (index 41)
02:35:52             async Suite.run (node:internal/test_runner/test:1217:7)
02:35:52             async Test.processPendingSubtests (node:internal/test_runner/test:565:7)
02:35:52           ...

it seems the CI doesn't always run in a TTY so output is not colored.

you should probably add this snippet to emulate coloring in all envs:

node/test/fixtures/test-runner/output/default_output.js

Lines 1 to 4 in 5905596

    
           'use strict'; 
        
           process.env.FORCE_COLOR = '1'; 
        
           delete process.env.NODE_DISABLE_COLORS; 
        
           delete process.env.NO_COLOR;

…tests

nodejs-github-bot · 2024-07-04T01:26:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60049/

puskin94 · 2024-07-22T07:32:05Z

Is this MR waiting for something else before "Landing" ? I am reading the docs and it looks like I have all the required steps? Or am I missing something?

PR-URL: nodejs#53450 Fixes: nodejs#51770 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MoLow · 2024-07-23T09:40:09Z

Landed in 8536b67

PR-URL: #53450 Fixes: #51770 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 14, 2024

puskin94 changed the title ~~lib: adding colors to the xs and dots in the test runner~~ lib: adding colors to the xs and dots in the dot test runner Jun 14, 2024

MoLow reviewed Jun 14, 2024

View reviewed changes

puskin94 requested a review from MoLow June 14, 2024 09:59

MoLow approved these changes Jun 14, 2024

View reviewed changes

RedYetiDev mentioned this pull request Jun 14, 2024

lib: adds colors to X's and .'s in test_runner dot reporter #52278

Closed

atlowChemi reviewed Jun 14, 2024

View reviewed changes

puskin94 requested a review from atlowChemi June 14, 2024 15:22

atlowChemi approved these changes Jun 14, 2024

View reviewed changes

lpinca approved these changes Jun 14, 2024

View reviewed changes

puskin94 force-pushed the make-dot-and-x-test-runner-colored branch 4 times, most recently from 8c23d44 to 73885f8 Compare June 15, 2024 08:24

Giovanni added 2 commits June 15, 2024 10:26

test_runner: added missing snapshot for the dot.js test

f957854

test_runner: adding colors to the xs and dots in the test runner

68aa96e

puskin94 force-pushed the make-dot-and-x-test-runner-colored branch from 73885f8 to 68aa96e Compare June 15, 2024 08:26

atlowChemi approved these changes Jun 15, 2024

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2024

puskin94 changed the title ~~lib: adding colors to the xs and dots in the dot test runner~~ test_runner: adding colors to the xs and dots in the dot test runner Jun 16, 2024

test_runner: deleting the env variables to disable colors in the dot …

3b50968

…tests

MoLow approved these changes Jul 2, 2024

View reviewed changes

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 4, 2024

MoLow closed this Jul 23, 2024

targos pushed a commit that referenced this pull request Jul 28, 2024

test_runner: added colors to dot reporter

c2f3311

PR-URL: #53450 Fixes: #51770 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS mentioned this pull request Jul 30, 2024

v22.6.0 proposal #54123

Merged

RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024

test_runner: added colors to dot reporter

4887213

PR-URL: #53450 Fixes: #51770 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

cjihrig mentioned this pull request Sep 19, 2024

dot reporter causes the terminal to clear since Node v22.8.0 #55009

Closed

targos pushed a commit that referenced this pull request Sep 21, 2024

test_runner: added colors to dot reporter

e41c095

PR-URL: #53450 Fixes: #51770 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos mentioned this pull request Sep 30, 2024

v20.18.0 release proposal #55170

Open

targos pushed a commit that referenced this pull request Oct 2, 2024

test_runner: added colors to dot reporter

c0b4c82

PR-URL: #53450 Fixes: #51770 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test_runner: adding colors to the xs and dots in the dot test runner #53450

test_runner: adding colors to the xs and dots in the dot test runner #53450

puskin94 commented Jun 14, 2024

nodejs-github-bot commented Jun 14, 2024

MoLow Jun 14, 2024

puskin94 Jun 14, 2024

RedYetiDev commented Jun 14, 2024

puskin94 commented Jun 14, 2024

RedYetiDev commented Jun 14, 2024 •

edited

Loading

atlowChemi Jun 14, 2024 •

edited

Loading

puskin94 Jun 14, 2024

jakecastelli commented Jun 14, 2024 •

edited

Loading

atlowChemi commented Jun 14, 2024

puskin94 commented Jun 15, 2024

nodejs-github-bot commented Jun 15, 2024

puskin94 commented Jun 24, 2024

MoLow commented Jun 26, 2024

nodejs-github-bot commented Jul 4, 2024

puskin94 commented Jul 22, 2024

MoLow commented Jul 23, 2024

		const { formatTestReport } = require('internal/test_runner/reporter/utils');
		const { red, white, green, clear } = require('internal/util/colors');

		const { formatTestReport } = require('internal/test_runner/reporter/utils');
		const colors = require('internal/util/colors');

test_runner: adding colors to the xs and dots in the dot test runner #53450

test_runner: adding colors to the xs and dots in the dot test runner #53450

Conversation

puskin94 commented Jun 14, 2024

nodejs-github-bot commented Jun 14, 2024

MoLow Jun 14, 2024

Choose a reason for hiding this comment

puskin94 Jun 14, 2024

Choose a reason for hiding this comment

RedYetiDev commented Jun 14, 2024

puskin94 commented Jun 14, 2024

RedYetiDev commented Jun 14, 2024 • edited Loading

atlowChemi Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

puskin94 Jun 14, 2024

Choose a reason for hiding this comment

jakecastelli commented Jun 14, 2024 • edited Loading

atlowChemi commented Jun 14, 2024

puskin94 commented Jun 15, 2024

nodejs-github-bot commented Jun 15, 2024

puskin94 commented Jun 24, 2024

MoLow commented Jun 26, 2024

nodejs-github-bot commented Jul 4, 2024

puskin94 commented Jul 22, 2024

MoLow commented Jul 23, 2024

RedYetiDev commented Jun 14, 2024 •

edited

Loading

atlowChemi Jun 14, 2024 •

edited

Loading

jakecastelli commented Jun 14, 2024 •

edited

Loading