src: move FromNamespacedPath to path.cc
#53540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
added
dont-land-on-v18.x
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
force-pushed
the
refactor-from-namespaced-path
branch
from
a73098a
to
ff82bc5
Compare
jasnell
reviewed
Jun 21, 2024
|
cc @nodejs/cpp-reviewers |
lemire
approved these changes
Jun 26, 2024
anonrig
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53540 ✔ Done loading data for nodejs/node/pull/53540 ----------------------------------- PR info ------------------------------------ Title src: move `FromNamespacedPath` to path.cc (#53540) Author Yagiz Nizipli (@anonrig) Branch anonrig:refactor-from-namespaced-path -> nodejs:main Labels c++, lib / src, author ready, needs-ci, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - src: move `FromNamespacedPath` to path.cc Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/53540 Reviewed-By: Daniel Lemire ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53540 Reviewed-By: Daniel Lemire -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 21 Jun 2024 22:15:46 GMT ✔ Approvals: 1 ✔ - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/53540#pullrequestreview-2142818588 ✘ This PR needs to wait 31 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-26T13:05:50Z: https://ci.nodejs.org/job/node-test-pull-request/59977/ - Querying data for job/node-test-pull-request/59977/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9698314507 |
H4ad
approved these changes
Jun 27, 2024
anonrig
added
commit-queue
H4ad
reviewed
Jun 27, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3036066 |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
PR-URL: #53540 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53540 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
->starts_with()is C++20, this pull-request can not land on v18 and v20.