tools: apply custom buffer lint rule to /lib only #5371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: nodejs#3983 (comment)
Trott
added
buffer
|
LGTM |
|
Good idea. That will also help to reduce the churn in #5053 LGTM |
|
Looks like Windows and ARM fanned hosts are not yet up and running on CI. Will try again later... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 25, 2016
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: nodejs#3983 (comment) PR-URL: nodejs#5371 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
CI is 💚 Landed in d26417f |
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: #3983 (comment) PR-URL: #5371 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: #3983 (comment) PR-URL: #5371 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: #3983 (comment) PR-URL: #5371 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: #3983 (comment) PR-URL: #5371 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint rule is there to avoid a circular-dependency issue that only
applies to
/lib. In preparation for linting/benchmark, apply thatrule to
/libonly to avoid churn in/benchmark.Refs: #3983 (comment)
/cc @silverwind