Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 12.9 #54536

Closed
wants to merge 13 commits into from
Closed

deps: update V8 to 12.9 #54536

wants to merge 13 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 24, 2024 •
edited
Loading

Notable changes:

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 24, 2024
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos
Copy link
Member Author

targos commented Aug 24, 2024

Updated d73e710 to fix the MSVC error.
Opened https://chromium-review.googlesource.com/c/v8/v8/+/5805956 upstream to fix the macOS Clang error.

@targos
Copy link
Member Author

targos commented Aug 24, 2024

@nodejs/platform-aix Can you have a look at https://ci.nodejs.org/job/node-test-commit-aix/53241/nodes=aix72-ppc64/console ?

@RedYetiDev RedYetiDev added the dependencies Pull requests that update a dependency file. label Aug 24, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61508/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6156/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6156/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6156/

@targos
Copy link
Member Author

targos commented Aug 27, 2024

https://ci.nodejs.org/job/node-test-commit-osx/60761/

@targos
Copy link
Member Author

targos commented Aug 27, 2024 •
edited
Loading

https://ci.nodejs.org/job/node-test-commit-windows-fanned/65162/
https://ci.nodejs.org/job/node-compile-windows-debug/23534/

@targos
Copy link
Member Author

targos commented Aug 27, 2024

https://ci.nodejs.org/job/node-test-commit-osx/60768/

@abmusse
Copy link
Contributor

abmusse commented Aug 27, 2024

@nodejs/platform-aix Can you have a look at https://ci.nodejs.org/job/node-test-commit-aix/53241/nodes=aix72-ppc64/console ?

Hello @targos I've opened a CL on v8 to resolve that build issue https://chromium-review.googlesource.com/c/v8/v8/+/5789180

@targos
Copy link
Member Author

targos commented Aug 27, 2024 •
edited
Loading

@nodejs/platform-windows, somehow Windows debug builds are broken. I tried two runs to be sure, but they both ended up in a timeout while building an addon: https://ci.nodejs.org/job/node-compile-windows-debug/23534/nodes=win-vs2022/console

@StefanStojanovic
Copy link
Contributor

@nodejs/platform-windows, somehow Windows debug builds are broken. I tried to runs to be sure, but they both ended up in a timeout while building an addon: https://ci.nodejs.org/job/node-compile-windows-debug/23534/nodes=win-vs2022/console

I'll look into it.

@StefanStojanovic
Copy link
Contributor

So what happens when you run that command (for me it is .\Debug\node.exe deps\npm\node_modules\node-gyp\bin\node-gyp rebuild --directory=test\addons\hello-world --nodedir="E:\work\node") after compiling in debug mode, is that you get this:

image

Clicking Ignore will get you through it, successfully but in CI we cannot do it. I'm not 100% sure, but I think we had this issue with some of the v12.x updates, Will try to find it.

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
32aec93 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
93ddd5c 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 21, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
8bfee76 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 21, 2024
@targos
deps: patch V8 to support older Clang versions
e5567aa 
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
6f6b35c 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
11ba45d 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 23, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
c055ca8 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 23, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
7ce7061 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 25, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
dab36e2 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 25, 2024
@targos
deps: patch V8 to support older Clang versions
bad5915 
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Sep 25, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
44e87c1 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Sep 25, 2024
@targos
deps: patch V8 to support older Clang versions
aec4ba1 
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 26, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
f717cff 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 26, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
8e3aa23 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 27, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
2c005ee 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 27, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
0553b5c 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 28, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
0d20113 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 28, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
527ed43 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 29, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
a55267f 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 29, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
f111430 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 30, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
a144dac 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 30, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
6b4005a 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Oct 1, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
888f157 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Oct 1, 2024
@targos
deps: patch V8 to support older Clang versions
20836ba 
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 1, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
a45d967 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 1, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
f141915 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 2, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
70edf6b 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 2, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
aa82b9b 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Oct 2, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
c6a5957 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Oct 2, 2024
@targos
deps: patch V8 to support older Clang versions
e68b2f6 
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @abmusse @StefanStojanovic @richardlau @gengjiawen @aduh95 @marco-ippolito @RedYetiDev