test: adding more tests for strip-types

[kevinuehara]

In this MR I'm adding more tests created in this PR, testing generics and Utility Types.
This PR makes part of typescript iniciative on Node.

cc: @RedYetiDev @marco-ippolito @ErickWendel

[nodejs-github-bot]

Review requested:

• @nodejs/typescript

[marco-ippolito]

Again commits do not point to your github profile or email

[RedYetiDev]

Again commits do not point to your github profile or email

The commits point to Kevin Uehara <kevin.uehara@ifood.com.br>, whereas your github profile's commits point to Gayathri <gayathriraj.vlr@gmail.com>

[kevinuehara]

@marco-ippolito @RedYetiDev I update the author of commits... the ifood account is my work author :)

[RedYetiDev]

@marco-ippolito how does this fixture compare to the other ones? Just want to make sure they are all similar

[marco-ippolito]

To be honest I dont think there is much value in testing TypeScript features such as Unions and Generics, since we rely on swc and swc tests that the output they produce is correct. Im ok with asserting that parameter properties throw in striptypes mode

[kevinuehara]

@marco-ippolito @RedYetiDev Do you think we can approve and merge this PR?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62690/

[mhdawson]

LGTM

[RedYetiDev]

@kevinuehara can you rebase/squash the merge commit + resolve the lint error?

[kevinuehara]

@kevinuehara can you rebase/squash the merge commit + resolve the lint error?

Sorry! But can you help me with the rebase/squash the merge coomit? Is there any command to solve the lint problem?

[RedYetiDev]

1. make lint-js will lint, while make lint-js-fix will fix some of the errors
2. git rebase -i HEAD~n, where n represents the number of commits, will open a UI where you can pick / squash commits. See https://www.freecodecamp.org/news/git-squash-commits/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (c237eab) to head (240c9e9).
Report is 95 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54929      +/-   ##
==========================================
- Coverage   88.26%   88.24%   -0.02%     
==========================================
  Files         652      652              
  Lines      183898   183898              
  Branches    35859    35858       -1     
==========================================
- Hits       162309   162286      -23     
- Misses      14891    14898       +7     
- Partials     6698     6714      +16     

see 24 files with indirect coverage changes

[kevinuehara]

@RedYetiDev I'm having some troube to use the squash/merge... I'm thinking to close this PR and open a new one, what do you think?

[RedYetiDev]

What's the issue you are having?

git reset --soft HEAD~<n> # where <n> represents the number of commits, in this case, 9
git commit

May also work. (See https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together)

[kevinuehara]

What's the issue you are having?

When I use the git rebase -i HEAD~2 all these commits appear due to the update with main:

[RedYetiDev]

Oh okay. IIRC what you'll want to do is get the latest commit from main, and run

git reset --hard <commit> # Right now it's c237eabf4c8f1d5ff6dfa95ae30930d6fc959d4e

Caution

This is a dangerous command. It'll remove all uncommitted changes, and revert your local workspace to look identical to <commit> (c237eab)

After this, re-add the changes from this PR. This can be done manually, or via git apply path/to/file.diff with the PR's diff file.

Once this is done, you can git add . and git commit

[kevinuehara]

@RedYetiDev I achieved! Thank you so much

[kevinuehara]

@RedYetiDev Is there anyone who can validate and merge the PR?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62855/

[kevinuehara]

@RedYetiDev @marco-ippolito I saw that an error was occurring in the tests, but it was not one that I created or changed. Can you help?

[marco-ippolito]

@RedYetiDev @marco-ippolito I saw that an error was occurring in the tests, but it was not one that I created or changed. Can you help?

Its just flaky tests Ill re run the CI

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62873/

[kevinuehara]

Thank you @marco-ippolito !!!

[nodejs-github-bot]

Landed in 2755551