Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix link in test/README.md #55165

Merged

Conversation

LiviaMedeiros
Copy link
Contributor

The relative link points to wrong place when the page is opened as https://github.com/nodejs/node/tree/main/test (without trailing slash nor explicit README.md), because new URL('./common/README.md', 'https://github.com/nodejs/node/tree/main/test').href === 'https://github.com/nodejs/node/tree/main/common/README.md'.

Note that there are similar links in other places (example:

See the json files in [the `status` folder](./status) for prerequisites,
), but they work fine because GitHub resolves them internally to absolute links. I guess it just doesn't touch links in footnotes.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 29, 2024
@LiviaMedeiros LiviaMedeiros added doc Issues and PRs related to the documentations. and removed needs-ci PRs that need a full CI run. labels Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (103b843) to head (8f1492c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55165   +/-   ##
=======================================
  Coverage   88.23%   88.24%           
=======================================
  Files         651      651           
  Lines      183863   183863           
  Branches    35824    35827    +3     
=======================================
+ Hits       162235   162245   +10     
+ Misses      14932    14923    -9     
+ Partials     6696     6695    -1     

see 24 files with indirect coverage changes

@RedYetiDev RedYetiDev added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 29, 2024
Copy link
Contributor

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

@RedYetiDev
Copy link
Member

Fast-tracking, as this is an extremely simple change, and shouldn't need to much deliberation?

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 29, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0f02810 into nodejs:main Sep 30, 2024
41 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0f02810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants