Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix TypeError exception when --enable-source-maps is passed #55231

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test_runner: fix TypeError exception when --enable-source-maps is passed #55231

wants to merge 3 commits into from
+17 −1

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Oct 2, 2024 •
edited
Loading

Split of #55228

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 2, 2024
@geeksilva97 geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from 3cf0246 to 4a29562 Compare October 2, 2024 03:33
@geeksilva97 geeksilva97 mentioned this pull request Oct 2, 2024
Draft
@geeksilva97 geeksilva97 marked this pull request as ready for review October 2, 2024 03:39
@geeksilva97 geeksilva97 changed the title Fix test runner when source maps is enabled test_runner: fix TypeError exception when --enable-source-maps is passed Oct 2, 2024
@geeksilva97 geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch 2 times, most recently from e0eb38c to f8c707c Compare October 2, 2024 03:49
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (d24c731) to head (d8a51cf).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55231      +/-   ##
==========================================
- Coverage   88.39%   88.39%   -0.01%     
==========================================
  Files         652      652              
  Lines      186568   186568              
  Branches    36047    36044       -3     
==========================================
- Hits       164924   164914      -10     
  Misses      14915    14915              
- Partials     6729     6739      +10
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.98% <100.00%> (ø)

... and 30 files with indirect coverage changes

@geeksilva97 geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from f8c707c to e440d39 Compare October 2, 2024 13:08
cjihrig
cjihrig reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the test is updated. It's odd that this does not appear to be an issue on Node 22.

test/parallel/test-runner-coverage.js Outdated
@@ -321,6 +321,43 @@ test('coverage with source maps', skipIfNoInspector, () => {
assert.strictEqual(result.status, 1);
});


test('coverage with --enable-source-maps option', skipIfNoInspector, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in a new file. This test is already flaky, plus this bug has nothing to do with coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you point me to the flakiness so I can fix it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the issue - #55154. FWIW, I ran a stress test locally (macOS) and could not reproduce the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a stress test locally (macOS) and could not reproduce the issue.

Omg. That's weird 🤔

test/parallel/test-runner-coverage.js Outdated Show resolved Hide resolved
@geeksilva97 geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from ae5b97f to 176b447 Compare October 2, 2024 14:14
@geeksilva97 geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from 176b447 to d8a51cf Compare October 2, 2024 14:18
@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62894/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62902/

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@RedYetiDev RedYetiDev Awaiting requested review from RedYetiDev

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geeksilva97 @nodejs-github-bot @cjihrig @RedYetiDev