Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: fix lint from 4fe02e2 #5825

Merged
merged 1 commit into from
Mar 21, 2016
Merged

timers: fix lint from 4fe02e2 #5825

merged 1 commit into from
Mar 21, 2016

Conversation

Fishrock123
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
    NOTE: these things are not required to open a PR and can be done
    afterwards / while the PR is open.

Affected core subsystem(s)

Description of change

Please provide a description of the change here.

Fixes: #5823
Refs: #5793

@Fishrock123
Copy link
Contributor Author

cc @Trott @mhdawson

@Fishrock123 Fishrock123 added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Mar 21, 2016
@MylesBorins
Copy link
Contributor

LGTM. should we run CI for posterity?

@Fishrock123
Copy link
Contributor Author

depends if you want to wait 5m or not

@Fishrock123
Copy link
Contributor Author

Here's a run anyway: https://ci.nodejs.org/job/node-test-pull-request/1996/

@whitlockjc
Copy link
Contributor

I was just about to tell you that I tested locally and that CI wasn't necessary. Probably best to had ran it anyways. ;)

@Fishrock123
timers: fix lint from 4fe02e2
d3a7534 
Fixes: nodejs#5823
Refs: nodejs#5793
PR-URL: nodejs#5825
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Fishrock123
Copy link
Contributor Author

some machines have passed, landed in d3a7534

@Fishrock123 Fishrock123 merged commit d3a7534 into nodejs:master Mar 21, 2016
@Fishrock123 Fishrock123 deleted the fix-lint-timers branch March 21, 2016 16:38
@Fishrock123 Fishrock123 mentioned this pull request Mar 22, 2016
Merged
Fishrock123 added a commit that referenced this pull request Mar 22, 2016
@Fishrock123
timers: fix lint from 4fe02e2
46f0e02 
Fixes: #5823
Refs: #5793
PR-URL: #5825
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 30, 2016
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fishrock123 @MylesBorins @whitlockjc