Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fix for #864 - report property attributes from sandbox object #885

Closed
wants to merge 1 commit into from
Closed

Partial fix for #864 - report property attributes from sandbox object #885

wants to merge 1 commit into from

Commits on Feb 19, 2015

  1. vm: pass attributes from sandbox 

    GlobalPropertyQueryCallback() was returning `None`
as attributes for all properties, without regard
to actual properties settings.

This patch looks up attributes for sandbox-defined
properties and returns them.  Partial fix for nodejsgh-864

Add test for nodejsgh-864, non-default settings of
object properties (e.g., `enumerable: false`) are not
visible when object is used as a sandbox
    @smikes
    smikes committed Feb 19, 2015
    Configuration menu
    Copy the full SHA
    2dfd002 View commit details
    Browse the repository at this point in the history