Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-net-GH-5504 #9461

Merged
merged 1 commit into from
Nov 6, 2016
Merged

test: fix flaky test-net-GH-5504 #9461

merged 1 commit into from
Nov 6, 2016

Conversation

santigimeno
Copy link
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

The test is failing on SmartOS quite often. Removing the timeout seems
to fix it.

It's an alternate fix to #9444

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2016
bnoordhuis
bnoordhuis approved these changes Nov 4, 2016
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it sure raises the question of why removing the watchdog timer would fix the flakiness.

@santigimeno
Copy link
Member Author

Could it be that if the timer fires and the server and/or client processes are still alive, killing them doesn't cause the process to exit immediately so the Hang timer fires?

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Nov 4, 2016
@santigimeno
Copy link
Member Author

Stress test: https://ci.nodejs.org/job/node-stress-single-test/nodes=smartos14-64/1052

@Trott Trott mentioned this pull request Nov 5, 2016
Closed
2 tasks
@Trott Trott added the smartos Issues and PRs related to the SmartOS platform. label Nov 6, 2016
@Trott
Copy link
Member

Trott commented Nov 6, 2016

Just a note that I think a Fixes: https://github.com/nodejs/node/issues/8930 metadata line can be added to the commit message now or else when landing.

@santigimeno
test: fix flaky test-net-nodejsGH-5504
f8f67d2 
The test is failing on `SmartOS` quite often. Removing the timeout seems
to fix it.

Fixes: nodejs#8930
PR-URL: nodejs#9461
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@santigimeno santigimeno merged commit f8f67d2 into nodejs:master Nov 6, 2016
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
@santigimeno @evanlucas
test: fix flaky test-net-GH-5504
6eb6816 
The test is failing on `SmartOS` quite often. Removing the timeout seems
to fix it.

Fixes: #8930
PR-URL: #9461
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@evanlucas evanlucas mentioned this pull request Nov 7, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@santigimeno
test: fix flaky test-net-GH-5504
093d677 
The test is failing on `SmartOS` quite often. Removing the timeout seems
to fix it.

Fixes: #8930
PR-URL: #9461
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@santigimeno @Trott @bnoordhuis @targos @cjihrig @mscdex @MylesBorins @nodejs-github-bot