fix: don't queue if destroyed

nodejs · Feb 27, 2021 · 3d002c1 · 3d002c1
1 parent 68356f3
commit 3d002c1
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/lib/core/client.js b/lib/core/client.js
@@ -628,17 +628,17 @@ class Parser extends HTTPParser {
   }
 
   [HTTPParser.kOnBody] (chunk, offset, length) {
-    if (this.paused) {
-      this.queue.push([HTTPParser.kOnBody, chunk, offset, length])
-      return
-    }
-
     const { socket, statusCode, request, timeout } = this
 
     if (socket.destroyed) {
       return
     }
 
+    if (this.paused) {
+      this.queue.push([HTTPParser.kOnBody, chunk, offset, length])
+      return
+    }
+
     if (timeout && timeout.refresh) {
       timeout.refresh()
     }
@@ -655,18 +655,17 @@ class Parser extends HTTPParser {
   }
 
   [HTTPParser.kOnMessageComplete] () {
-    /* istanbul ignore next: difficult to make a test case for */
-    if (this.paused) {
-      this.queue.push([HTTPParser.kOnMessageComplete])
-      return
-    }
-
     const { client, socket, statusCode, headers, upgrade, request, trailers } = this
 
     if (socket.destroyed) {
       return
     }
 
+    if (this.paused) {
+      this.queue.push([HTTPParser.kOnMessageComplete])
+      return
+    }
+
     assert(statusCode >= 100)
     assert(this.resuming || (socket._handle && socket._handle.reading))