fix: use TypeError

Fixes: #1098
nodejs · Nov 15, 2021 · 64d07c3 · 64d07c3
1 parent e659683
commit 64d07c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/lib/fetch/headers.js b/lib/fetch/headers.js
@@ -6,10 +6,6 @@ const { validateHeaderName, validateHeaderValue } = require('http')
 const { kHeadersList } = require('../core/symbols')
 const { kGuard } = require('./symbols')
 const { kEnumerableProperty } = require('../core/util')
-const {
-  InvalidHTTPTokenError,
-  HTTPInvalidHeaderValueError
-} = require('../core/errors')
 const {
   forbiddenHeaderNames,
   forbiddenResponseHeaderNames
@@ -34,7 +30,7 @@ function binarySearch (arr, val) {
 
 function normalizeAndValidateHeaderName (name) {
   if (name === undefined) {
-    throw new InvalidHTTPTokenError(`Header name ${name}`)
+    throw new TypeError(`Header name ${name}`)
   }
   const normalizedHeaderName = name.toLocaleLowerCase()
   validateHeaderName(normalizedHeaderName)
@@ -43,7 +39,7 @@ function normalizeAndValidateHeaderName (name) {
 
 function normalizeAndValidateHeaderValue (name, value) {
   if (value === undefined) {
-    throw new HTTPInvalidHeaderValueError(value, name)
+    throw new TypeError(value, name)
   }
   const normalizedHeaderValue = `${value}`.replace(
     /^[\n\t\r\x20]+|[\n\t\r\x20]+$/g,

diff --git a/test/fetch/headers.js b/test/fetch/headers.js
@@ -10,10 +10,6 @@ const {
   fill
 } = require('../../lib/fetch/headers')
 const { kHeadersList } = require('../../lib/core/symbols')
-const {
-  InvalidHTTPTokenError,
-  HTTPInvalidHeaderValueError
-} = require('../../lib/core/errors')
 const { kGuard } = require('../../lib/fetch/symbols')
 const {
   forbiddenHeaderNames,
@@ -489,12 +485,12 @@ tap.test('arg validation', (t) => {
   // normalizeAndValidateHeaderName
   t.throws(() => {
     normalizeAndValidateHeaderName()
-  }, InvalidHTTPTokenError)
+  }, TypeError)
 
   // normalizeAndValidateHeaderValue
   t.throws(() => {
     normalizeAndValidateHeaderValue()
-  }, HTTPInvalidHeaderValueError)
+  }, TypeError)
 
   // fill
   t.throws(() => {