Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: don't use pooled buffer in body mixin #3377

Closed

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Jun 26, 2024

completely fix #3337

@tsctx tsctx requested a review from KhafraDev June 26, 2024 12:16
@tsctx
Copy link
Member Author

tsctx commented Jun 26, 2024

@mcollina
there are many such cases, should they be fixed?

@KhafraDev
Copy link
Member

I think there's still some questions left to answer here. Mostly: is this something we need? If not (and I am assuming we don't), what benefit is there in adding it?

@tsctx
Copy link
Member Author

tsctx commented Jun 27, 2024

is this something we need? If not (and I am assuming we don't), what benefit is there in adding it?

I also have my doubts. but, double cloning can be avoided, as in the commit just added.

In fact, it is not skipping the spec, but creating a new arraybuffer at safeBufferConcat according to this, which should not be a violation of the spec.

Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not interested in any solution that changes around the steps in the spec

@tsctx
Copy link
Member Author

tsctx commented Jun 27, 2024

Hmm... If I was to say it, It is completely fix #3337, but we may not need to worry about pooled buffer.

@tsctx tsctx closed this Jun 27, 2024
@tsctx tsctx deleted the fetch/do-not-use-pooled-buffer-in-body-mixin branch June 28, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch arrayBuffer() leaks random data from process memory
3 participants