Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

add tests and API documentation #51

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

othiym23
Copy link
Contributor

This is a WIP:

  • tests and documentation for Abstract (base class)
  • tests and documentation for Reader
  • tests and documentation for Writer
  • tests and documentation for File
  • tests and documentation for Dir
  • tests and documentation for Link
  • tests and documentation for Proxy
  • tests for collect
  • tests for getTypes
  • port and viciously dewhimsify examples scenarios into tests
  • add regression test for dir-reader: account for entries being changed after _read #50

r: @zkat
r: @iarna

evanlucas and others added 6 commits April 28, 2016 14:58
If this.entries is changed after _read() has been called, we will be
out of sync and try to access an invalid index of this.entries. When
the entry cannot be found, we emit end and close, which can drop files
from reading.
@coveralls
Copy link

coveralls commented Apr 29, 2016

Coverage Status

Coverage decreased (-51.4%) to 22.433% when pulling a395f7e on othiym23/add-tests into 3258080 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants