send: construct PreBlock instead of PreHeader to create PreCommit #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PreHeader is not enough to create PreCommit because PreCommit requires the whole set of transactions to be available for PreCommit data calculations. This bug leads to the fact that Primary node can't properly construct valid PreCommit message because block's transactions are not yet filled by dBFT by this moment. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 59.47% 59.47%
=======================================
Files 32 32
Lines 1821 1821
=======================================
Hits 1083 1083
Misses 659 659
Partials 79 79 ☔ View full report in Codecov by Sentry. |
|
OK, it should be fine. |
roman-khimov
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreHeader is not enough to create PreCommit because PreCommit requires the whole set of transactions to be available for PreCommit data calculations. This bug leads to the fact that Primary node can't properly construct valid PreCommit message because block's transactions are not yet filled by dBFT by this moment.
Required by https://github.com/bane-labs/go-ethereum/pull/287.
Draft because I need to carefully ensure that nothing is broken by this change for non-primary nodes. I checked that
CreatePreBlockis called only when all transactions are available (as expected).