*: extend PreBlock processing callback #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPKE decryption shares verification is performed in ProcessPreBlock callback when PreBlock is already constructed and all transactions are available. If some of the received shares can't decrypt Envelopes' content then dBFT should wait for more PreCommit payloads from other "honest" CNs. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
It's a must-have condition for PreBlock construction. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
PreCommits can't be verified against PreHeader because PreCommit carries transactions-sensitive information. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
PreBlock may be created earlier at the PreCommit verification level, and it's OK. However, it's required at least M PreCommits to _process_ PreBlock. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 59.47% 59.25% -0.22%
==========================================
Files 32 32
Lines 1821 1831 +10
==========================================
+ Hits 1083 1085 +2
- Misses 659 665 +6
- Partials 79 81 +2 ☔ View full report in Codecov by Sentry. |
roman-khimov
reviewed
Sep 2, 2024
Move hasAllTransactions check from PreBlock constructor to onPreCommit callback. The rest of CreatePreBlock usages already have this check. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov
approved these changes
Sep 3, 2024
|
I found one more bug. |
|
@roman-khimov, I placed encrypted data decoding to the wrong dBFT callback, so the library itself works correctly, the mistae was on the NeoX side. Ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The necessity of this extension is described in https://github.com/bane-labs/go-ethereum/pull/301#discussion_r1726514210. We need at least
Mcorrect PreCommits to decrypt Envelopes content, but decryption may be checked only by using the group of PreCommits. Thus, we can't say whether a single PreCommit can/can't decrypt Envelopes content.@roman-khimov, please, review it carefully, I checked what I could and there seems to be no tricks possible to skip verification, but maybe you'll fined something. May be it'll be easier to review if you take a look at https://github.com/bane-labs/go-ethereum/pull/287/commits/f4e830c751ae6a4ee94adb6db42096133abfa235.