Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of exported BLS12-381 specific groth16.VerifyingKey structure #3079

Closed
AnnaShaleva opened this issue Aug 3, 2023 · 0 comments · Fixed by #3145
Closed

Make use of exported BLS12-381 specific groth16.VerifyingKey structure #3079

AnnaShaleva opened this issue Aug 3, 2023 · 0 comments · Fixed by #3145
Labels
enhancement Improving existing functionality

Comments

@AnnaShaleva
Copy link
Member

We have to keep an eye on https://github.com/Consensys/gnark/milestone/6. As soon as it's released, we need to use exported BLS12-381-specific groth16.VerifyingKey structure instead of a common groth16.VerifyingKey interface that is currently in use in our zkpbinding package. All the public key serialization-related code is expected to be gone from zkpbinding.

Make the same for groth16.Proof if it's possible after v0.9.0 release of gnark.

Ref. Consensys/gnark#799 (comment), ref. #3043.
@AnnaShaleva AnnaShaleva added the enhancement Improving existing functionality label Aug 3, 2023
AnnaShaleva added a commit that referenced this issue Oct 4, 2023
@AnnaShaleva
*: migrate onto gnark@v0.9.0 and add production CRS generation instru…
ddc4383 
…ctions

1. Close #3079 by using new exported gnark@v0.9.0 APIs.
2. Add an example and instructions for production CRS generation.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 4, 2023
@AnnaShaleva
*: migrate onto gnark@v0.9.0 and add production CRS generation instru…
b17a84b 
…ctions

1. Close #3079 by using new exported gnark@v0.9.0 APIs.
2. Add an example and instructions for production CRS generation.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 4, 2023
@AnnaShaleva
*: migrate onto gnark@v0.9.0 and add production CRS generation instru…
8c828ab 
…ctions

1. Close #3079 by using new exported gnark@v0.9.0 APIs.
2. Add an example and instructions for production CRS generation.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 5, 2023
@AnnaShaleva
*: migrate onto gnark@v0.9.0 and add production CRS generation instru…
ee802f5 
…ctions

1. Close #3079 by using new exported gnark@v0.9.0 APIs.
2. Add an example and instructions for production CRS generation.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 5, 2023
@AnnaShaleva
*: migrate onto gnark@v0.9.0 and add production CRS generation instru…
74cfc62 
…ctions

1. Close #3079 by using new exported gnark@v0.9.0 APIs.
2. Add an example and instructions for production CRS generation.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva mentioned this issue Oct 5, 2023
Merged
3 tasks
AnnaShaleva added a commit that referenced this issue Oct 5, 2023
@AnnaShaleva
go.mod: upgrade gnark to v0.9.0
3ac6665 
Close #3079.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva mentioned this issue Oct 5, 2023
Merged
AnnaShaleva added a commit that referenced this issue Oct 5, 2023
@AnnaShaleva
go.mod: upgrade gnark to v0.9.0
fa8eba7 
Close #3079.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 16, 2023
@AnnaShaleva
go.mod: upgrade gnark to v0.9.0
545dbbc 
Close #3079.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go.mod: upgrade gnark to v0.9.0 nspcc-dev/neo-go
1 participant
@AnnaShaleva