Manifest and script checks #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was used when manifests were saved into JSON.
Make it a little more convenient to work with it.
Be more specific.
Some methods must be defined in a valid ABI. Refs. neo-project/neo#2263.
Strange as it is but I wasn't able to find any good bit field implementation. Most of them are limited to 64 bits, some allow for wider values (like https://github.com/emef/bitfield) but even they're not that efficient (using bytes instead of wider types). This this minimalistic thing.
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
+ Coverage 82.53% 82.73% +0.20%
==========================================
Files 255 261 +6
Lines 21532 21765 +233
==========================================
+ Hits 17772 18008 +236
+ Misses 2657 2651 -6
- Partials 1103 1106 +3
Continue to review full report at Codecov.
|
AnnaShaleva
approved these changes
Feb 10, 2021
fyrchik
approved these changes
Feb 10, 2021
| case PermissionWildcard: | ||
| bad = true | ||
| case PermissionHash: | ||
| if contracts[i].Hash() == contracts[j].Hash() { |
There was a problem hiding this comment.
bad = contracts[i].Hash() == contracts[j].Hash() ?
| } | ||
|
|
||
| // Equals compares two Fields and returns true if they're equal. | ||
| func (f Field) Equals(o Field) bool { |
There was a problem hiding this comment.
I'd expect it to compare f to o as sets (as len guarantee can't be provided fully because of upper-rounding in New). But if we don't need this, ok.
AnnaShaleva
added a commit
that referenced
this pull request
Jul 4, 2023
This check is good and was present here since #1729, but it was accidently removed from the reference implementation (see the discussion in neo-project/neo#2848). The removal of this check from the C# node leaded to the T5 testnet state diff since 1670095 heigh which causes inability to process new blocks since 2272533 height (see #3049). This check was added back to the C# node in neo-project/neo#2849, but it is planned to be the part of the upcoming 3.6.0 C# node release. We need to keep our testnet healthy, thus, strict contract script check will be temporary removed from the node code and is planned to be added back to be a part of the next 3.6.0-compatible release. Close #3049.
AnnaShaleva
added a commit
that referenced
this pull request
Jul 4, 2023
This check is good and was present here since #1729, but it was accidently removed from the reference implementation (see the discussion in neo-project/neo#2848). The removal of this check from the C# node leaded to the T5 testnet state diff since 1670095 heigh which causes inability to process new blocks since 2272533 height (see #3049). This check was added back to the C# node in neo-project/neo#2849, but it is planned to be the part of the upcoming 3.6.0 C# node release. We need to keep our testnet healthy, thus, strict contract script check will be temporary removed from the node code and is planned to be added back to be a part of the next 3.6.0-compatible release. Close #3049. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Jul 4, 2023
This check is good and was present here since #1729, but it was accidently removed from the reference implementation (see the discussion in neo-project/neo#2848). The removal of this check from the C# node leaded to the T5 testnet state diff since 1670095 heigh which causes inability to process new blocks since 2272533 height (see #3049). This check was added back to the C# node in neo-project/neo#2849, but it is planned to be the part of the upcoming 3.6.0 C# node release. We need to keep our testnet healthy, thus, strict contract script check will be temporary removed from the node code and is planned to be added back to be a part of the next 3.6.0-compatible release. Close #3049. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Jul 8, 2023
This check is good and was present here since #1729, but it was accidently removed from the reference implementation (see the discussion in neo-project/neo#2848). The removal of this check from the C# node leaded to the T5 testnet state diff since 1670095 heigh which causes inability to process new blocks since 2272533 height (see #3049). This check was added back to the C# node in neo-project/neo#2849, but it is planned to be the part of the upcoming 3.6.0 C# node release. We need to keep our testnet healthy, thus, strict contract script check will be temporary removed from the node code and is planned to be added back to be a part of the next 3.6.0-compatible release. Close #3049. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1699.
Solution
Merge.