native: add committee change events #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AnnaShaleva
requested changes
Mar 14, 2024
AliceInHunterland
force-pushed
the
CommitteeChanged
branch
2 times, most recently
from
59d47f7
to
7a2e79e
Compare
AliceInHunterland
force-pushed
the
CommitteeChanged
branch
2 times, most recently
from
e325924
to
104e913
Compare
AnnaShaleva
reviewed
Mar 18, 2024
AliceInHunterland
force-pushed
the
CommitteeChanged
branch
2 times, most recently
from
41239c8
to
20fa789
Compare
AnnaShaleva
reviewed
Mar 18, 2024
There was a problem hiding this comment.
To fix failing findstorage tests just update the testchain's block 20 stateroot, it was changed after one of the previous PRs:
diff --git a/pkg/services/rpcsrv/server_test.go b/pkg/services/rpcsrv/server_test.go
index c0b0fe15..f66844da 100644
--- a/pkg/services/rpcsrv/server_test.go
+++ b/pkg/services/rpcsrv/server_test.go
@@ -87,7 +87,7 @@ const (
faultedTxHashLE = "82279bfe9bada282ca0f8cb8e0bb124b921af36f00c69a518320322c6f4fef60"
faultedTxBlock uint32 = 23
invokescriptContractAVM = "VwIADBQBDAMOBQYMDQIODw0DDgcJAAAAAErZMCQE2zBwaEH4J+yMqiYEEUAMFA0PAwIJAAIBAwcDBAUCAQAOBgwJStkwJATbMHFpQfgn7IyqJgQSQBNA"
- block20StateRootLE = "858c873539d6d24a70f2be13f9dafc61aef2b63c2aa16bb440676de6e44e3cf1"
+ block20StateRootLE = "397c69adbc0201d59623fa913bfff4a2da25c792c484d1d278c061709f2c21cf"
)
var (
20fa789
to
2c86876
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3351 +/- ##
==========================================
+ Coverage 84.79% 84.83% +0.03%
==========================================
Files 331 331
Lines 44939 44961 +22
==========================================
+ Hits 38107 38143 +36
+ Misses 5319 5309 -10
+ Partials 1513 1509 -4 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
force-pushed
the
CommitteeChanged
branch
from
2c86876
to
cca430b
Compare
Port neo-project/neo#3158. Close #3326 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
CommitteeChanged
branch
from
cca430b
to
7c25755
Compare
AnnaShaleva
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port neo-project/neo#3158.
Close #3326